Note that versionTimestamps are only loaded on the active node. #13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nale: that's the only place they're needed currently, and making them available on perf standbys would take some extra work, e.g. invalidation. I was going to add a more specific error message to FindOldestVersionTimestamp (the only consumer atm), but that func is invoked both with and without the statelock, making it tricky to determine if we're a standby.
HridoyRoy
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: that's the only place they're needed currently, and making them reliably available on perf standbys would take some extra work, e.g. invalidation.
I was going to add a more specific error message to FindOldestVersionTimestamp (the only consumer atm), but
that func is invoked both with and without the statelock, making it tricky to determine if we're a standby.