Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Custom empty state messages for transit and transform #13090

Merged
merged 6 commits into from Nov 12, 2021

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Nov 9, 2021

Previous empty state message read the following for secret backends:
Screen Shot 2021-11-08 at 9 11 08 PM

Updated copy for transform and transit:
Screen Shot 2021-11-08 at 9 10 57 PM

Screen Shot 2021-11-08 at 9 12 18 PM

@vercel vercel bot temporarily deployed to Preview – vault November 9, 2021 00:54 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 9, 2021 01:03 Inactive
@hellobontempo hellobontempo added this to the 1.10 milestone Nov 9, 2021
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion, but looks great!

ui/app/helpers/options-for-backend.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault November 11, 2021 23:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 11, 2021 23:36 Inactive
@hellobontempo hellobontempo merged commit 6725a37 into main Nov 12, 2021
@hellobontempo hellobontempo deleted the ui/transit-visual-changes branch November 12, 2021 00:53
qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
…3090)

* customizes empty state messages for transit and transform

* adds changelog

* clarifies key name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants