Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.16.12. #13417

Merged
merged 10 commits into from Dec 14, 2021
Merged

Upgrade to Go 1.16.12. #13417

merged 10 commits into from Dec 14, 2021

Conversation

ncabatoff
Copy link
Contributor

No description provided.

@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 19:12 Inactive
# Conflicts:
#	.circleci/config.yml
#	.circleci/config/commands/go_test.yml
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 20:18 Inactive
jasonodonnell and others added 3 commits December 14, 2021 15:19
* creds/aws: import pkcs7 verification package

* Add DSA support

* changelog

* Add DSA to correct verify function

* Remove unneeded tests

* Fix backend test

* Update builtin/credential/aws/pkcs7/README.md

Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>

* Update builtin/credential/aws/path_login.go

Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>

Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 20:20 Inactive
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me, but I feel uncomfortable being the only reviewer for this sort of upgrade change to a stable product release.

@vercel vercel bot temporarily deployed to Preview – vault-storybook December 14, 2021 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – vault December 14, 2021 21:08 Inactive
@ncabatoff ncabatoff merged commit e10e350 into release/1.7.x Dec 14, 2021
@ncabatoff ncabatoff deleted the move-to-go-1.16 branch December 14, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants