Quit agent endpoint with config #14223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @taoism4504 for documentation updates |
benashz
reviewed
Feb 23, 2022
tvoran
reviewed
Feb 23, 2022
benashz
reviewed
Feb 23, 2022
calvn
reviewed
Feb 23, 2022
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
|
Thanks for the reviews. I think that's all comments addressed. Docs site deployment link is here if you'd like to browse: https://vault-aq18lm9e5-hashicorp.vercel.app/docs/agent#api |
tvoran
approved these changes
Feb 24, 2022
calvn
approved these changes
Feb 24, 2022
benashz
reviewed
Feb 25, 2022
| } | ||
|
|
||
| // Get a randomly assigned port and then free it again before returning it. | ||
| // There is still a race when trying to use it, but should work better |
There was a problem hiding this comment.
The risk of a port collision should be relatively low since most kernels incrementally assign ports from their dynamic range of many thousands of ports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #12789 and closes #11089
Support a quit API endpoint so that when Vault Agent can be programatically shut down. This is useful for instance when Agent is a sidecar in a Kubernetes job to stop the job from hanging forever. Currently the only workarounds are to use
shareProcessNamespace: truefor the container so that process kill signals can be sent, or to avoid the sidecar container entirely and just rely on an init container.