Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix incorrect validity modal on transit secrets engine #14233

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

hashishaw
Copy link
Collaborator

Prior to this fix, validity was not being properly passed which resulted in incorrect information to the user. See before/after gifs.

BEFORE

before

AFTER
after

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.9.x labels Feb 23, 2022
@hashishaw hashishaw added this to the 1.10 milestone Feb 23, 2022
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 23, 2022 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 23, 2022 20:28 Inactive
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault UI > Transit > Verify: UI shows verification is false despite api showing its correct
2 participants