Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSCT Optimizations (OSS) #14323

Merged
merged 4 commits into from
Mar 1, 2022
Merged

SSCT Optimizations (OSS) #14323

merged 4 commits into from
Mar 1, 2022

Conversation

HridoyRoy
Copy link
Contributor

This PR addresses the lingering comments from: #14109

@vercel vercel bot temporarily deployed to Preview – vault-storybook March 1, 2022 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 1, 2022 19:11 Inactive
@HridoyRoy HridoyRoy requested a review from ncabatoff March 1, 2022 19:12
@HridoyRoy HridoyRoy added this to the 1.10-rc1 milestone Mar 1, 2022
ncabatoff
ncabatoff approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion.

vault/core_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 1, 2022 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 1, 2022 19:22 Inactive
@HridoyRoy HridoyRoy merged commit 88dbb8a into main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
pr/no-changelog
Projects
None yet
Milestone
1.10-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HridoyRoy @ncabatoff