MFA Config #15200

zofskeez · 2022-04-27T18:09:07Z

Side branch for merging phase 2 mfa config feature work.

* adds mfa login enforcement model, adapter and serializer * updates mfa methods to hasMany realtionship and transforms property names * updates login enforcement adapter to use urlForQuery over buildURL

* Model for mfa method * Added adapter and serializer for mfa method - Updated mfa method model - Basic route to handle list view - Added MFA to access nav * Show landing page if methods are not configured * Updated adapter,serializer - Backend is adding new endpoint to list all the mfa methods * Updated landing page - Added MFA diagram - Created helper to resolve full path for assets like images * Remove ember assign * Fixed failing test

* MFA method and enforcement list view - Added new route for list views - List mfa methods along with id, type and icon - Added client side pagination to list views * Throw error if method id is not present

* adds mfa login enforcement form and header components and radio card component * skips login enforcement form tests for now * adds jsdoc annotations for mfa-login-enforcement-header component * adds error handling when fetching identity targets in login enforcement form component * updates radio-card label elements

* adds mfa login enforcement form and header components and radio card component * skips login enforcement form tests for now * updates to login enforcement form to fix issues hydrating methods and targets from model when editing * updates to mfa-config mirage handler and login enforcement handler * fixes issue with login enforcement serializer normalizeItems method throwing error on save * updates to mfa route structure * adds login enforcement create and edit routes

* adds login enforcement read views * skip mfa-method-list-item test for now

* MFA method form - Updated model for form attributes - Form for editing, creating mfa methods * Added comments * Update model for mfa method * Refactor buildURL in mfa method adapter * Update adapter to handle mfa create * Fixed adapter to handle create mfa response

* initial setup of components and route * fix navbar * replace parent component with controller * use auth service to return entity id * adapter and some error handling: * clean up adapter and handle warning * wip * use library for qrCode generation * clear warning and QR code display fix * flow for restart setup * add documentation * clean up * fix warning issue * handle root user * remove comment * update copy * fix margin * address comment

* adds mfa method create route with type selection workflow * updates mfa method create route links to use DocLink component

* adds mfa guided setup config view * resets type query param on mfa method create route exit * hide next button if type is not selected in mfa method create route * updates to sure correct state when changing mfa method type in guided setup

- List enforcements for each mfa method - Delete MFA method if no enforcements are present - Moved method, enforcement list item component to mfa folder

* adds model and form validations for mfa login enforcements * updates mfa login enforcement validation messages * updates validation message for mfa login enforcement targets * adds transition action to configure mfa button on landing page * unset enforcement on preference change in mfa guided setup workflow

* add active class when on index * breadcrumbs * remove box-shadow to match designs * fix refresh load mfa-method * breadcrumb create * add an empty state the enforcements list view * change to beforeModel

* remove pagintion and fix on methods list view * fix enforcements

* adds tests for mfa-login-enforcement-header component * adds tests for mfa-login-enforcement-form component

- use passcode had a default value, as a result it was being sent with all the mfa method types during save and edit flows..

hashishaw

Love all those tests 😍 Some comments but nothing blocking. Great work team!

ui/app/adapters/mfa-login-enforcement.js

ui/app/adapters/mfa-method.js

ui/app/components/auth-info.js

ui/app/components/mfa-form.js

hashishaw · 2022-05-20T18:09:16Z

ui/app/routes/vault/cluster/access/mfa/methods/method/edit.js

@@ -0,0 +1,3 @@
+import Route from '@ember/routing/route';
+
+export default class MfaMethodEditRoute extends Route {}


Doesn't this route need the model of the MFA being edited?

The parent method route loads the model and it gets passed down to the child. It's funny though I can't seem to find anywhere in the documentation that mentions that if you do not define a model hook in a child route it receives the parent model. Maybe that's not a thing but it's definitely getting the model from the parent.

And here I thought it was a standard practice in ember that model gets passed down to child. 😆

ui/app/serializers/mfa-login-enforcement.js

ui/app/templates/components/mfa-setup-step-two.hbs

* data-test-mleh -> data-test-mfa * Only one label per radio card * Remove unnecessary async * Simplify boolean logic * Make mutation clear * Revert "data-test-mleh -> data-test-mfa" This reverts commit 31430df.

…for current mounts as targets (#15547)

* remove token type * conditional param

…ethod route on save success

mdeggies · 2022-05-20T22:30:15Z

I believe all of the CI jobs are running now :)
The root issue was that the CircleCI CI config was updated in main but this branch hadn't pulled in those changes yet. Feel free to reach back out if you run into any other issues.

* adds mirage factories for mfa methods and login enforcement * adds mirage handler for mfa config endpoints * adds mirage identity manager for uuids * updates mfa test to use renamed mfaLogin mirage handler * updates mfa login workflow for push methods (hashicorp#15214) * MFA Login Enforcement Model (hashicorp#15244) * adds mfa login enforcement model, adapter and serializer * updates mfa methods to hasMany realtionship and transforms property names * updates login enforcement adapter to use urlForQuery over buildURL * Model for mfa method (hashicorp#15218) * Model for mfa method * Added adapter and serializer for mfa method - Updated mfa method model - Basic route to handle list view - Added MFA to access nav * Show landing page if methods are not configured * Updated adapter,serializer - Backend is adding new endpoint to list all the mfa methods * Updated landing page - Added MFA diagram - Created helper to resolve full path for assets like images * Remove ember assign * Fixed failing test * MFA method and enforcement list view (hashicorp#15353) * MFA method and enforcement list view - Added new route for list views - List mfa methods along with id, type and icon - Added client side pagination to list views * Throw error if method id is not present * MFA Login Enforcement Form (hashicorp#15410) * adds mfa login enforcement form and header components and radio card component * skips login enforcement form tests for now * adds jsdoc annotations for mfa-login-enforcement-header component * adds error handling when fetching identity targets in login enforcement form component * updates radio-card label elements * MFA Login Enforcement Create and Edit routes (hashicorp#15422) * adds mfa login enforcement form and header components and radio card component * skips login enforcement form tests for now * updates to login enforcement form to fix issues hydrating methods and targets from model when editing * updates to mfa-config mirage handler and login enforcement handler * fixes issue with login enforcement serializer normalizeItems method throwing error on save * updates to mfa route structure * adds login enforcement create and edit routes * MFA Login Enforcement Read Views (hashicorp#15462) * adds login enforcement read views * skip mfa-method-list-item test for now * MFA method form (hashicorp#15432) * MFA method form - Updated model for form attributes - Form for editing, creating mfa methods * Added comments * Update model for mfa method * Refactor buildURL in mfa method adapter * Update adapter to handle mfa create * Fixed adapter to handle create mfa response * Sidebranch: MFA end user setup (hashicorp#15273) * initial setup of components and route * fix navbar * replace parent component with controller * use auth service to return entity id * adapter and some error handling: * clean up adapter and handle warning * wip * use library for qrCode generation * clear warning and QR code display fix * flow for restart setup * add documentation * clean up * fix warning issue * handle root user * remove comment * update copy * fix margin * address comment * MFA Guided Setup Route (hashicorp#15479) * adds mfa method create route with type selection workflow * updates mfa method create route links to use DocLink component * MFA Guided Setup Config View (hashicorp#15486) * adds mfa guided setup config view * resets type query param on mfa method create route exit * hide next button if type is not selected in mfa method create route * updates to sure correct state when changing mfa method type in guided setup * Enforcement view at MFA method level (hashicorp#15485) - List enforcements for each mfa method - Delete MFA method if no enforcements are present - Moved method, enforcement list item component to mfa folder * MFA Login Enforcement Validations (hashicorp#15498) * adds model and form validations for mfa login enforcements * updates mfa login enforcement validation messages * updates validation message for mfa login enforcement targets * adds transition action to configure mfa button on landing page * unset enforcement on preference change in mfa guided setup workflow * Added validations for mfa method model (hashicorp#15506) * UI/mfa breadcrumbs and small fixes (hashicorp#15499) * add active class when on index * breadcrumbs * remove box-shadow to match designs * fix refresh load mfa-method * breadcrumb create * add an empty state the enforcements list view * change to beforeModel * UI/mfa small bugs (hashicorp#15522) * remove pagintion and fix on methods list view * fix enforcements * Fix label for value on radio-card (hashicorp#15542) * MFA Login Enforcement Component Tests (hashicorp#15539) * adds tests for mfa-login-enforcement-header component * adds tests for mfa-login-enforcement-form component * Remove default values from mfa method model (hashicorp#15540) - use passcode had a default value, as a result it was being sent with all the mfa method types during save and edit flows.. * UI/mfa small cleanup (hashicorp#15549) * data-test-mleh -> data-test-mfa * Only one label per radio card * Remove unnecessary async * Simplify boolean logic * Make mutation clear * Revert "data-test-mleh -> data-test-mfa" This reverts commit 31430df. * updates mfa login enforcement form to only display auth method types for current mounts as targets (hashicorp#15547) * remove token type (hashicorp#15548) * remove token type * conditional param * removes type from mfa method payload and fixes bug transitioning to method route on save success * removes punctuation from mfa form error message string match * updates qr-code component invocation to angle bracket * Re-trigger CI jobs with empty commit Co-authored-by: Arnav Palnitkar <arnav@hashicorp.com> Co-authored-by: Angel Garbarino <Monkeychip@users.noreply.github.com> Co-authored-by: Chelsea Shaw <82459713+hashishaw@users.noreply.github.com> Co-authored-by: Michele Degges <mdeggies@gmail.com>

zofskeez added 3 commits April 27, 2022 12:04

adds mirage factories for mfa methods and login enforcement

38c0b61

adds mirage handler for mfa config endpoints

f8bed48

adds mirage identity manager for uuids

7694c06

zofskeez added ui pr/no-changelog labels Apr 27, 2022

zofskeez added this to the 1.11.0-rc1 milestone Apr 27, 2022

zofskeez and others added 20 commits April 27, 2022 12:22

updates mfa test to use renamed mfaLogin mirage handler

44ff84b

updates mfa login workflow for push methods (#15214)

c7a19b8

MFA Login Enforcement Model (#15244)

c99b6cc

* adds mfa login enforcement model, adapter and serializer * updates mfa methods to hasMany realtionship and transforms property names * updates login enforcement adapter to use urlForQuery over buildURL

MFA method and enforcement list view (#15353)

dcca74b

* MFA method and enforcement list view - Added new route for list views - List mfa methods along with id, type and icon - Added client side pagination to list views * Throw error if method id is not present

MFA Login Enforcement Read Views (#15462)

9c0ed26

* adds login enforcement read views * skip mfa-method-list-item test for now

MFA Guided Setup Route (#15479)

0bc5c3a

* adds mfa method create route with type selection workflow * updates mfa method create route links to use DocLink component

MFA Guided Setup Config View (#15486)

e780d1c

* adds mfa guided setup config view * resets type query param on mfa method create route exit * hide next button if type is not selected in mfa method create route * updates to sure correct state when changing mfa method type in guided setup

Enforcement view at MFA method level (#15485)

8d774cc

- List enforcements for each mfa method - Delete MFA method if no enforcements are present - Moved method, enforcement list item component to mfa folder

Added validations for mfa method model (#15506)

0e1adf6

UI/mfa breadcrumbs and small fixes (#15499)

da24f4b

* add active class when on index * breadcrumbs * remove box-shadow to match designs * fix refresh load mfa-method * breadcrumb create * add an empty state the enforcements list view * change to beforeModel

UI/mfa small bugs (#15522)

75630ef

* remove pagintion and fix on methods list view * fix enforcements

Fix label for value on radio-card (#15542)

e248ddc

MFA Login Enforcement Component Tests (#15539)

cac3f67

* adds tests for mfa-login-enforcement-header component * adds tests for mfa-login-enforcement-form component

Remove default values from mfa method model (#15540)

f498c3a

- use passcode had a default value, as a result it was being sent with all the mfa method types during save and edit flows..

hashishaw approved these changes May 20, 2022

View reviewed changes

hashishaw mentioned this pull request May 20, 2022

UI/mfa small cleanup #15549

Merged

hashishaw and others added 2 commits May 20, 2022 13:52

UI/mfa small cleanup (#15549)

04279d4

* data-test-mleh -> data-test-mfa * Only one label per radio card * Remove unnecessary async * Simplify boolean logic * Make mutation clear * Revert "data-test-mleh -> data-test-mfa" This reverts commit 31430df.

updates mfa login enforcement form to only display auth method types …

c1d661b

…for current mounts as targets (#15547)

Monkeychip and others added 4 commits May 20, 2022 13:05

remove token type (#15548)

e38e69f

* remove token type * conditional param

removes type from mfa method payload and fixes bug transitioning to m…

ff5146c

…ethod route on save success

removes punctuation from mfa form error message string match

36d4107

updates qr-code component invocation to angle bracket

d62ed0d

zofskeez marked this pull request as ready for review May 20, 2022 20:27

arnav28 approved these changes May 20, 2022

View reviewed changes

mdeggies added 2 commits May 20, 2022 14:32

Re-trigger CI jobs with empty commit

ac1cc1a

Merge remote-tracking branch 'origin' into ui/mfa-config

7f889ba

vercel bot deployed to Preview May 20, 2022 22:29 View deployment

Monkeychip merged commit ca14c19 into main May 21, 2022

Monkeychip deleted the ui/mfa-config branch May 21, 2022 00:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MFA Config #15200

MFA Config #15200

zofskeez commented Apr 27, 2022

hashishaw left a comment •

edited

hashishaw May 20, 2022

zofskeez May 20, 2022

arnav28 May 20, 2022

mdeggies commented May 20, 2022

		@@ -0,0 +1,3 @@
		import Route from '@ember/routing/route';

		export default class MfaMethodEditRoute extends Route {}

MFA Config #15200

MFA Config #15200

Conversation

zofskeez commented Apr 27, 2022

hashishaw left a comment • edited

Choose a reason for hiding this comment

hashishaw May 20, 2022

Choose a reason for hiding this comment

zofskeez May 20, 2022

Choose a reason for hiding this comment

arnav28 May 20, 2022

Choose a reason for hiding this comment

mdeggies commented May 20, 2022

hashishaw left a comment •

edited