Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DR Metric scraping capability to debug command #15316

Merged
merged 8 commits into from
May 6, 2022

Conversation

davidadeleon
Copy link
Contributor

This PR adds the ability for vault debug to scrape telemetry data from a DR Secondary cluster if unauthenticated_metrics_access is enabled on the listener. Debug will also skip targets that are invalid against any DR Secondaries to avoid expected error noise.

Example:

❯ ./vault debug -duration=10s
Overwriting interval value "30s" to the duration value "10s"
Ignoring invalid targets for DR Secondary: config, host, log, pprof, requests
==> Starting debug capture...
         Vault Address: http://127.0.0.1:8202
        Client Version: 1.11.0-dev1
        Server Version: 1.10.0+ent
              Duration: 10s
              Interval: 10s
      Metrics Interval: 10s
               Targets: metrics, replication-status, server-status
                Output: vault-debug-2022-05-06T14-50-27Z.tar.gz

==> Capturing static information...

==> Capturing dynamic information...
2022-05-06T10:50:27.686-0400 [INFO]  capturing server status: count=0
2022-05-06T10:50:27.686-0400 [INFO]  capturing metrics: count=0
2022-05-06T10:50:27.686-0400 [INFO]  capturing replication status: count=0
2022-05-06T10:50:37.688-0400 [INFO]  capturing replication status: count=1
2022-05-06T10:50:37.688-0400 [INFO]  capturing server status: count=1
2022-05-06T10:50:37.689-0400 [INFO]  capturing metrics: count=1
Finished capturing information, bundling files...
Success! Bundle written to: vault-debug-2022-05-06T14-50-27Z.tar.gz

Adding additional information around ability to gather metrics from DR secondary
changelog/15316.txt Outdated Show resolved Hide resolved
@jasonodonnell jasonodonnell self-requested a review May 6, 2022 18:45
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, but looks good to me!

davidadeleon and others added 3 commits May 6, 2022 14:46
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
@davidadeleon davidadeleon merged commit 254d8da into main May 6, 2022
@davidadeleon davidadeleon deleted the davidadeleon-add-dr-metrics-to-debug branch May 6, 2022 20:04
jasonodonnell added a commit that referenced this pull request May 12, 2022
* Add server information as well as ability to collect metrics from DR secondary

* Update debug docs

Adding additional information around ability to gather metrics from DR secondary

* Fix broken link in updated doc

* Create 15316.txt

Create changelog entry

* Fix Formatting

* Update website/content/docs/commands/debug.mdx

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Update changelog/15316.txt

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Trigger Build

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
davidadeleon added a commit that referenced this pull request May 12, 2022
* Add server information as well as ability to collect metrics from DR secondary

* Update debug docs

Adding additional information around ability to gather metrics from DR secondary

* Fix broken link in updated doc

* Create 15316.txt

Create changelog entry

* Fix Formatting

* Update website/content/docs/commands/debug.mdx

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Update changelog/15316.txt

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Trigger Build

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
davidadeleon added a commit that referenced this pull request May 17, 2022
* Add server information as well as ability to collect metrics from DR secondary

* Update debug docs

Adding additional information around ability to gather metrics from DR secondary

* Fix broken link in updated doc

* Create 15316.txt

Create changelog entry

* Fix Formatting

* Update website/content/docs/commands/debug.mdx

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Update changelog/15316.txt

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

* Trigger Build

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants