Vault 5917 allow patch operations to pki roles issuers #15510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y roles after migration.
cipherboy
requested review from
stevendpclark and
cipherboy
and removed request for
stevendpclark
cipherboy
approved these changes
May 20, 2022
There was a problem hiding this comment.
This largely looks good! I have passing tests for role based patching but I think we can add this in a separate PR.
Thank you @kitography!
| // When the new name is in use but isn't this name, throw an error. | ||
| return logical.ErrorResponse(err.Error()), nil | ||
| } | ||
| if newName != issuer.Name { |
There was a problem hiding this comment.
Verify if we are writing a new name, if non-zero, that it matches nameMatcher.MatchString(newName) so that we have valid names to be use within URLs.
I'm okay with deferring this to another PR as we are missing it here and within the pathUpdateIssuer handler.
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
* Add a warning when Issuing Certificate set on a role does not resolve. * Ivanka's requests - add a warning on deleting issuer or changing it's name. * Fix nil checks; reduce number of roles to iterate through; only verify roles after migration. * Fix semgrep failure, ignore roles deleted behind our back. * Patch functionality for roles * Make Patch Roles work again, add back patch issuers. * Add changelog. * Fix nil-reversion on empty response. * Panics are bad. don't do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATCH functionality for Roles and Issuers