Allow issuer/:issuer_ref/sign-verbatim/:role, add error on missing role #15543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
approved these changes
May 20, 2022
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-allow-issuer-sign-verbatim
branch
from
91af569
to
4f7275b
Compare
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-allow-issuer-sign-verbatim
branch
from
6628b03
to
9603194
Compare
Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
cipherboy
changed the title
|
Thanks all! Merging... |
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
…le (hashicorp#15543) * Allow role-based sign-verbatim with chosen issuer Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> * Add warning with missing requested verbatim role Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> * Add changelog Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com> * Update builtin/logical/pki/backend.go Co-authored-by: Steven Clark <steven.clark@hashicorp.com> Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15277, we missed that the new
/issuer/issuer_ref/sign-verbatimpath lacked a role-allowed variant (like/sign-verbatim/:roledoes). Add the missing parameter.Additionally, I noticed that
sign-verbatim(since early versions), wouldn't warn or err on a missing role when one was requested. Since we don't currently err, we can't now err, so add a warning instead.