Convert not_before_duration to seconds before returning it #15559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gabrielopesantos Thanks for catching this! I'll take a look on Monday, but I've tagged us so we'll hopefully remember. |
cipherboy
approved these changes
May 23, 2022
Gabrielopesantos
added a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
…#15559) * Convert not_before_duration to seconds before returning it * changelog file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found a bug in an improvement that was merged to main the other day (#15250).
The SSH Role field
not_before_durationfield is returned in nanoseconds instead of seconds (as expected).The following requests fixes this issue by converting the value of the fields to seconds before returning it.
Screenshots of the bug (
not_before_durationmeant to be 30 seconds)PS: The screenshots are a bit bigger than expected.
Others
Not sure if it's worth creating an issue for this.
@cipherboy
Sorry for pinging, just thought it would be faster since you have context of what was done.