Fix linter issues in policy.go & acl.go #16366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averche
changed the title
averche
commented
Jul 19, 2022
| } | ||
| } | ||
| if pc.DeniedParametersHCL != nil { | ||
| pc.Permissions.DeniedParameters = make(map[string][]interface{}, len(pc.DeniedParametersHCL)) | ||
|
|
||
| for key, val := range pc.DeniedParametersHCL { | ||
| pc.Permissions.DeniedParameters[strings.ToLower(key)] = val | ||
| for k, v := range pc.DeniedParametersHCL { |
There was a problem hiding this comment.
key was shadowing another variable in the scope
averche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few small issues I noticed while looking into policy parameter constraints:
nilwas passed to context in tests; replaced it withcontext.Background()t.Fatalwas being used inside of internal go-routines, which would not fail the test; changed the test to push errors into a channel and check them at the endcopyandappendinstead of loops to copy/append slices