Vault 7338/fix retry join #16550
Merged
Vault 7338/fix retry join #16550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8db66f4853abce3f432adcf1724b1f237b275415 introduced an error wherein a join() would return nil (no error) with no information on its channel if a joining node had been initialized. This was not handled properly by the caller and resulted in a canceled `retry_join`. Fix this by handling the `nil` channel respone by treating it as an error and allowing the existing mechanics to work as intended.
ncabatoff
approved these changes
Aug 3, 2022
akshya96
reviewed
Aug 3, 2022
mpalmi
commented
Aug 4, 2022
This was referenced Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug found in #16486
The
retry_joinloop inJoinRaftClustercontinues to execute if a call tojoin()returns with an error.Commit introduced a change which removes an erroneous error wrapper, but did not
handle the case where a join was in progress and err == nil. This ends the
retry_joinloop and prevents a node from waiting to join.Fix this by handling the
nilchannel response and returning anerror, allowing the
retry_jointo continue.