Add support for a dedicated HMAC type in Transit. #16668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schultz-is
reviewed
Aug 10, 2022
schultz-is
reviewed
Aug 10, 2022
Co-authored-by: Matt Schultz <975680+schultz-is@users.noreply.github.com>
Co-authored-by: Matt Schultz <975680+schultz-is@users.noreply.github.com>
stevendpclark
approved these changes
Aug 11, 2022
schultz-is
approved these changes
Aug 11, 2022
schultz-is
reviewed
Aug 12, 2022
cipherboy
reviewed
Aug 16, 2022
| @@ -600,7 +601,7 @@ func generateKey(keyType string) (interface{}, error) { | |||
| switch keyType { | |||
| case "aes128-gcm96": | |||
| return uuid.GenerateRandomBytes(16) | |||
| case "aes256-gcm96": | |||
| case "aes256-gcm96", "hmac": | |||
There was a problem hiding this comment.
I think we want to actually generate 64 bytes for hmac?
My 2c., but since SHA-256 uses a 512-bit block (which I think is what HMAC is using under the covers, but it isn't clear from my quick glance) -- a 32-byte key would be padded with 32 bytes of zeros, I'd rather we use all the bits since we can.
I'm also generally interested in extensibility. Do you see us adding SHA-512? SHA-3? If so, where/how?
Definitely like this though!
There was a problem hiding this comment.
We could add hash function as a sub param. I think I like that rather than a plethora of distinct types.
Co-authored-by: Matt Schultz <975680+schultz-is@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to be used with BYOK. We also add a key_size parameter for
this type, since HMAC supports any sized key, though we limit it to 256-4096
bits.