Fix naming of permitted_dns_domains in webui #16739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKI has consistently used permitted_dns_domains since it was originally introduced as a parameter. However, it appears the Web UI was updated to add this field, but used an incorrect internal identifier (permittedDnsNames rather than permittedDnsDomains). This triggers a warning from the backend about an unknown parameter, and the domain restriction isn't added: > Endpoint ignored these unrecognized parameters: [permitted_dns_names] Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added
ui
bug
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
hashishaw
approved these changes
Aug 16, 2022
hellobontempo
approved these changes
Aug 16, 2022
|
Adding 1.10.x tag to see if this backports cleanly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKI has consistently used
permitted_dns_domainssince it was originallyintroduced as a parameter. However, it appears the Web UI was updated to
add this field (n.b.: prior to the move to OSS), but used an incorrect internal identifier
(
permittedDnsNamesrather thanpermittedDnsDomains).This triggers a warning from the backend about an unknown parameter, and
the domain restriction isn't added:
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>I think with the changes to the UI files, this'll apply cleanly on 1.11, but not sure the backport to 1.10.x will work. :-) I'll let you do that @hellobontempo if that's desired.
Before:
After: