PKI Redesign: setup Ember Engine

[Monkeychip]

This PR is the first of the PKI redesign project. We will be pushing our changes to main, but keeping the work hidden behind an Ember engine (later exposed in the 1.13 release). The mount for this engine will be commented out on the router.js file so a user can't accidentally fall upon the new routing. Thus, you should never see a pki mount added to the router.js file until the project is ready.

Notes:

1. The new engine—similar to KMIP—can be reached when added as a mount in the router.js file as http://localhost:4200/ui/vault/secrets/pki-1/pki/<route> where pki-1 is the secret engine mount's name.

Compare this to the current route (which doesn't have the appended pki).
http://localhost:4200/ui/vault/secrets/pki-1/<route>

3. Ran test locally, twice in a row, including Enterprise. Everything looked good.

4. If you want to test on the ui, be sure to yarn install before hand (And you'll need to yarn install when you move off the branch too).

[hellobontempo]

Should we update this syntax to extends Engine - that way we can also remove the eslint-disable comment?

Sample below from ember engines quickstart which is also what Chelsea's used in the Vault Insights engine PR

// addon/engine.js
import Engine from '@ember/engine';

import loadInitializers from 'ember-load-initializers';
import Resolver from 'ember-resolver';

import config from './config/environment';

const { modulePrefix } = config;

export default class PkiEngine extends Engine {
  modulePrefix = modulePrefix;
  Resolver = Resolver;
}

loadInitializers(PkiEngine, modulePrefix);

[Monkeychip]

Thank you for pointing this out! I'll update.

[hellobontempo]

Can we delete this file if wherever we have import Resolver from './resolver'; we change to import Resolver from 'ember-resolver';

[hellobontempo]

Also taken from the quickstart guide, but could we do something like this instead?

const { buildEngine } = require('ember-engines/lib/engine-addon');

module.exports = buildEngine({
  name: 'pki',
  lazyLoading: {
    enabled: false
  }
});

[hellobontempo]

Just some comments! As I haven't worked much with engines I'm not confident enough in to give a full approval

[zofskeez]

Just a thought but if you used the environment from the config (which is already imported in the router file) you could conditionally use the mount for development and not have to worry about commenting it out. Something like this:

if (config.environment !== 'production') {
  this.mount('pki');
}

[Monkeychip]

Great idea! Amended, and tested.

[zofskeez]

I have a question about the routing. If the engine is pki would it make more sense for that to come before the dyanmic engine name?
http://localhost:4200/ui/vault/secrets/pki/<engine-name>/<route>

[zofskeez]

Looks like you're off to a good start. Thanks!