Setup Routing for PKI tabs #17054
Merged
Setup Routing for PKI tabs #17054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
commented
Sep 9, 2022
Monkeychip
commented
Sep 9, 2022
zofskeez
approved these changes
Sep 9, 2022
| @@ -0,0 +1,3 @@ | |||
| import Route from '@ember/routing/route'; | |||
|
|
|||
| export default class CertificatesRoute extends Route {} | |||
There was a problem hiding this comment.
Just a nit on class naming here. In the case that an error is thrown it might be nice to see a more specific name in the stack trace like PkiCertificatesRoute.
Comment on lines
+1
to
+39
| <SecretListHeader | ||
| @model={{this.model}} | ||
| @backendCrumb={{hash | ||
| label=this.model.id | ||
| text=this.model.id | ||
| path="vault.cluster.secrets.backend.list-root" | ||
| model=this.model.id | ||
| }} | ||
| @isEngine={{true}} | ||
| /> | ||
| <Toolbar> | ||
| <ToolbarActions> | ||
| <ToolbarLink @params={{array "configuration.tidy"}}> | ||
| Tidy | ||
| </ToolbarLink> | ||
| <ToolbarLink @params={{array "configuration.edit"}}> | ||
| Edit configuration | ||
| </ToolbarLink> | ||
| </ToolbarActions> | ||
| </Toolbar> | ||
|
|
||
| <div class="form-section"> | ||
| <label class="title has-padding-top is-5"> | ||
| URLs | ||
| </label> | ||
| </div> | ||
| <div class="form-section"> | ||
| <label class="title has-padding-top is-5"> | ||
| CRL | ||
| </label> | ||
| </div> | ||
| <div class="form-section"> | ||
| <label class="title has-padding-top is-5"> | ||
| Mount Configuration | ||
| </label> | ||
| <div class="box is-fullwidth is-sideless is-paddingless is-marginless"> | ||
| {{! ARG TODO component and empty state }} | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
I know this is still WIP but wanted to confirm that this will become a component because I think it's used in other routes as well?
There was a problem hiding this comment.
Good catch. The empty state section will, yep, and then I'll use the infoTableRows components for the three chunks of data dispaled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKI route infrastructure work to get things setup.
This does not cover the creation of all the routes (specifically the nested configuration routes), but gives a pretty good layout of the approach.
Below is a video of how the routing looks.
NOTES:
SecretListHeadercomponents on the tab routes allows me to see the breadcrumbs/title/tabs every time I switch to another tab.ember g route <route path> -in-repo pkito generate a route in the pki engine it automatically creates a duplicate app folder with the route files. I normally remember not to commit these, but I've committed two accidentally in the overview route and delete them here in this pr. You'll see them deleted at the end of the list of "Files changed."routing.mov