Fix unsafe access to perf standby status from systemview #17186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by() from dynamicSystemView, which might be accessed with or without stateLock held.
ncabatoff
changed the title
mpalmi
reviewed
Sep 19, 2022
raskchanky
reviewed
Sep 19, 2022
| mountEntry: entry, | ||
| core: c, | ||
| mountEntry: entry, | ||
| perfStandby: c.perfStandby, |
There was a problem hiding this comment.
Is the enclosing function here called with whatever lock is appropriate to access c.perfStandby?
There was a problem hiding this comment.
Yes. During a mount request, it's a request, so we hold the read stateLock as with most regular requests. During a post-unseal setupMounts, the write stateLock is held.
mpalmi
added
core
raskchanky
approved these changes
Sep 20, 2022
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
…7186) Ensure that we don't try to access Core.perfStandby or Core.PerfStandby() from dynamicSystemView, which might be accessed with or without stateLock held.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we don't try to access Core.perfStandby or Core.PerfStandby() from dynamicSystemView, which might be accessed with or without stateLock held.