Template lint warning clean up #17432

zofskeez · 2022-10-05T18:43:03Z

There were no new template lint errors after the Ember 4.4 upgrade but warnings left over from the previous upgrade were cleaned up.

zofskeez · 2022-10-05T18:44:44Z

ui/.template-lintrc.js

-    'no-bare-strings': 'off',
    'no-action': 'off',
-    'no-duplicate-landmark-elements': 'warn',
    'no-implicit-this': {
      allow: ['supported-auth-backends'],
    },
    'require-input-label': 'off',
-    'no-down-event-binding': 'warn',
-    'self-closing-void-elements': 'off',


To avoid future issues these have been removed and the defaults (most likely error) will be applied.

ui/app/components/diff-version-selector.js

ui/app/templates/components/file-to-array-buffer.hbs

zofskeez · 2022-10-05T18:53:30Z

ui/app/templates/components/namespace-link.hbs

-        {{! template-lint-configure no-nested-interactive "warn" }}
-        <button type="button" class="button is-ghost icon">
-          <Chevron @isButton={{true}} class="has-text-grey" />
-        </button>
-        {{! template-lint-configure no-nested-interactive "on" }}
+        <Chevron @isButton={{true}} class="button is-ghost icon has-text-grey" />


Adding the classes directly to the Chevron preserves styling and since there was no onclick handler on the button I was able to remove it.

only thoughts about this approach are accessibility. Does Chevron use the button element? (screen readers, from what I understand, use the keyword button to help indicate what can be clicked).

I'm not sure what you mean by use the button element. From what I can tell the interactive element is the link and if anything I think it would be worse for screen readers to have a nested interactive element that doesn't do anything (the button).

I'm definitely not an expert when it comes to accessibility and it seems like in some of the older code it was an after thought so there isn't always a pattern to take as an example.

ui/app/templates/components/database-connection.hbs

ui/app/templates/vault/cluster/access/identity/show.hbs

Monkeychip

LGTM. I learn a lot every time I work through these upgrade PRs—good reminders of patterns to avoid.

* runs ember-cli-update to 4.4.0 * updates yarn.lock * updates dependencies causing runtime errors (#17135) * Inject Store Service When Accessed Implicitly (#17345) * adds codemod for injecting store service * adds custom babylon parser with decorators-legacy plugin for jscodeshift transforms * updates inject-store-service codemod to only look for .extend object expressions and adds recast options * runs inject-store-service codemod on js files * replace query-params helper with hash (#17404) * Updates/removes dependencies throwing errors in Ember 4.4 (#17396) * updates ember-responsive to latest * updates ember-composable-helpers to latest and uses includes helper since contains was removed * updates ember-concurrency to latest * updates ember-cli-clipboard to latest * temporary workaround for toolbar-link component throwing errors for using params arg with LinkTo * adds missing store injection to auth configure route * fixes issue with string-list component throwing error for accessing prop in same computation * fixes non-iterable query params issue in mfa methods controller * refactors field-to-attrs to handle belongsTo rather than fragments * converts mount-config fragment to belongsTo on auth-method model * removes ember-api-actions and adds tune method to auth-method adapter * converts cluster replication attributes from fragment to relationship * updates ember-data, removes ember-data-fragments and updates yarn to latest * removes fragments from secret-engine model * removes fragment from test-form-model * removes commented out code * minor change to inject-store-service codemod and runs again on js files * Remove LinkTo positional params (#17421) * updates ember-cli-page-object to latest version * update toolbar-link to support link-to args and not positional params * adds replace arg to toolbar-link component * Clean up js lint errors (#17426) * replaces assert.equal to assert.strictEqual * update eslint no-console to error and disables invididual intended uses of console * cleans up hbs lint warnings (#17432) * Upgrade bug and test fixes (#17500) * updates inject-service codemod to take arg for service name and runs for flashMessages service * fixes hbs lint error after merging main * fixes flash messages * updates more deps * bug fixes * test fixes * updates ember-cli-content-security-policy and prevents default form submission throwing errors * more bug and test fixes * removes commented out code * fixes issue with code-mirror modifier sending change event on setup causing same computation error * Upgrade Clean Up (#17543) * updates deprecation workflow and filter * cleans up build errors, removes unused ivy-codemirror and sass and updates ember-cli-sass and node-sass to latest * fixes control groups test that was skipped after upgrade * updates control group service tests * addresses review feedback * updates control group service handleError method to use router.currentURL rather that transition.intent.url * adds changelog entry

* runs ember-cli-update to 4.4.0 * updates yarn.lock * updates dependencies causing runtime errors (hashicorp#17135) * Inject Store Service When Accessed Implicitly (hashicorp#17345) * adds codemod for injecting store service * adds custom babylon parser with decorators-legacy plugin for jscodeshift transforms * updates inject-store-service codemod to only look for .extend object expressions and adds recast options * runs inject-store-service codemod on js files * replace query-params helper with hash (hashicorp#17404) * Updates/removes dependencies throwing errors in Ember 4.4 (hashicorp#17396) * updates ember-responsive to latest * updates ember-composable-helpers to latest and uses includes helper since contains was removed * updates ember-concurrency to latest * updates ember-cli-clipboard to latest * temporary workaround for toolbar-link component throwing errors for using params arg with LinkTo * adds missing store injection to auth configure route * fixes issue with string-list component throwing error for accessing prop in same computation * fixes non-iterable query params issue in mfa methods controller * refactors field-to-attrs to handle belongsTo rather than fragments * converts mount-config fragment to belongsTo on auth-method model * removes ember-api-actions and adds tune method to auth-method adapter * converts cluster replication attributes from fragment to relationship * updates ember-data, removes ember-data-fragments and updates yarn to latest * removes fragments from secret-engine model * removes fragment from test-form-model * removes commented out code * minor change to inject-store-service codemod and runs again on js files * Remove LinkTo positional params (hashicorp#17421) * updates ember-cli-page-object to latest version * update toolbar-link to support link-to args and not positional params * adds replace arg to toolbar-link component * Clean up js lint errors (hashicorp#17426) * replaces assert.equal to assert.strictEqual * update eslint no-console to error and disables invididual intended uses of console * cleans up hbs lint warnings (hashicorp#17432) * Upgrade bug and test fixes (hashicorp#17500) * updates inject-service codemod to take arg for service name and runs for flashMessages service * fixes hbs lint error after merging main * fixes flash messages * updates more deps * bug fixes * test fixes * updates ember-cli-content-security-policy and prevents default form submission throwing errors * more bug and test fixes * removes commented out code * fixes issue with code-mirror modifier sending change event on setup causing same computation error * Upgrade Clean Up (hashicorp#17543) * updates deprecation workflow and filter * cleans up build errors, removes unused ivy-codemirror and sass and updates ember-cli-sass and node-sass to latest * fixes control groups test that was skipped after upgrade * updates control group service tests * addresses review feedback * updates control group service handleError method to use router.currentURL rather that transition.intent.url * adds changelog entry

cleans up hbs lint warnings

af85758

zofskeez added the ui label Oct 5, 2022

zofskeez commented Oct 5, 2022

View reviewed changes

ui/app/components/diff-version-selector.js Show resolved Hide resolved

zofskeez commented Oct 5, 2022

View reviewed changes

ui/app/templates/components/file-to-array-buffer.hbs Show resolved Hide resolved

zofskeez commented Oct 5, 2022

View reviewed changes

Monkeychip reviewed Oct 5, 2022

View reviewed changes

ui/app/templates/components/database-connection.hbs Show resolved Hide resolved

Monkeychip reviewed Oct 5, 2022

View reviewed changes

ui/app/templates/vault/cluster/access/identity/show.hbs Show resolved Hide resolved

Monkeychip approved these changes Oct 5, 2022

View reviewed changes

zofskeez merged commit c890712 into ui/ember-upgrade-4.4 Oct 5, 2022

zofskeez deleted the ui/VAULT-8280/hbs-lint-warnings branch October 5, 2022 21:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Template lint warning clean up #17432

Template lint warning clean up #17432

zofskeez commented Oct 5, 2022 •

edited

zofskeez Oct 5, 2022

zofskeez Oct 5, 2022

Monkeychip Oct 5, 2022

zofskeez Oct 5, 2022

Monkeychip left a comment

Template lint warning clean up #17432

Template lint warning clean up #17432

Conversation

zofskeez commented Oct 5, 2022 • edited

zofskeez Oct 5, 2022

Choose a reason for hiding this comment

zofskeez Oct 5, 2022

Choose a reason for hiding this comment

Monkeychip Oct 5, 2022

Choose a reason for hiding this comment

zofskeez Oct 5, 2022

Choose a reason for hiding this comment

Monkeychip left a comment

Choose a reason for hiding this comment

zofskeez commented Oct 5, 2022 •

edited