PKI role create: fix issue with setting default key_bits on init and when key_type changes #17613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
commented
Oct 19, 2022
| @@ -10,10 +10,10 @@ | |||
| /> | |||
| <Toolbar> | |||
There was a problem hiding this comment.
These changes fix something that seemed to have broken after the ember upgrade.
There was a problem hiding this comment.
Yes I had to refactor the ToolbarLink since passing positional params into LinkTo is no longer supported
zofskeez
approved these changes
Oct 19, 2022
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
…when key_type changes (hashicorp#17613) * working * fix issue with signature bits * fix ember upgrade change * clean up * fix signature bits to number * default value in model * fix language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where the
keyBitvalue was not being set on init nor was it being set whenkeyTypechanged, even though the dropdown options were changing.I pulled all the conditional options work out of the model, and moved it all into a component. This should help clarify what's going on, and move semi-complication logic work out of the model. Also, it will help organize testing.
keyparams.mov
In the API you can see the default key_bits set for each key_type.
And the default key_type is
rsa. You can test this in the current PKI. Even though we don't send this default value in the old PKI, the read view shows rsa and 2048.