Eslint prefer-const #17864
Merged
Eslint prefer-const #17864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
commented
Nov 9, 2022
Comment on lines
-129
to
+139
| let csvData = [], | ||
| csvHeader = [ | ||
| 'Namespace path', | ||
| 'Authentication method', | ||
| 'Total clients', | ||
| 'Entity clients', | ||
| 'Non-entity clients', | ||
| ]; | ||
| const csvData = []; | ||
| const csvHeader = [ | ||
| 'Namespace path', | ||
| 'Authentication method', | ||
| 'Total clients', | ||
| 'Entity clients', | ||
| 'Non-entity clients', | ||
| ]; | ||
|
|
||
| if (newAttribution) { | ||
| csvHeader = [...csvHeader, 'Total new clients, New entity clients, New non-entity clients']; | ||
| csvHeader.push('Total new clients, New entity clients, New non-entity clients'); |
zofskeez
commented
Nov 9, 2022
Comment on lines
-4
to
-14
| let ret; | ||
| ret = payload.data.keys.map((key) => { | ||
| let model = { | ||
| return payload.data.keys.map((key) => { | ||
| const model = { | ||
| id: key, | ||
| }; | ||
| if (payload.backend) { | ||
| model.backend = payload.backend; | ||
| } | ||
| return model; | ||
| }); | ||
| return ret; |
zofskeez
commented
Nov 9, 2022
Comment on lines
-21
to
-31
| let ret; | ||
| ret = payload.data.keys.map((key) => { | ||
| let model = { | ||
| return payload.data.keys.map((key) => { | ||
| const model = { | ||
| id: key, | ||
| }; | ||
| if (payload.backend) { | ||
| model.backend = payload.backend; | ||
| } | ||
| return model; | ||
| }); | ||
| return ret; |
zofskeez
commented
Nov 9, 2022
Comment on lines
-5
to
-15
| let ret; | ||
| ret = payload.data.keys.map((key) => { | ||
| let model = { | ||
| return payload.data.keys.map((key) => { | ||
| const model = { | ||
| id: key, | ||
| }; | ||
| if (payload.backend) { | ||
| model.backend = payload.backend; | ||
| } | ||
| return model; | ||
| }); | ||
| return ret; |
zofskeez
commented
Nov 9, 2022
Comment on lines
-43
to
-53
| let ret; | ||
| ret = payload.data.keys.map((key) => { | ||
| let model = { | ||
| return payload.data.keys.map((key) => { | ||
| const model = { | ||
| id: key, | ||
| }; | ||
| if (payload.backend) { | ||
| model.backend = payload.backend; | ||
| } | ||
| return model; | ||
| }); | ||
| return ret; |
zofskeez
commented
Nov 9, 2022
Comment on lines
-9
to
+17
| let itemID; | ||
| let aliasID; | ||
| let idRow; | ||
| if (itemType === 'groups') { | ||
| await createItemPage.createItem(itemType, 'external'); | ||
| await settled(); | ||
| } else { | ||
| await createItemPage.createItem(itemType); | ||
| await settled(); | ||
| } | ||
| idRow = showItemPage.rows.filterBy('hasLabel').filterBy('rowLabel', 'ID')[0]; | ||
| itemID = idRow.rowValue; | ||
| let idRow = showItemPage.rows.filterBy('hasLabel').filterBy('rowLabel', 'ID')[0]; | ||
| const itemID = idRow.rowValue; |
zofskeez
commented
Nov 9, 2022
Comment on lines
-67
to
+78
| let itemID; | ||
| let aliasID; | ||
| let idRow; | ||
| if (itemType === 'groups') { | ||
| await createItemPage.createItem(itemType, 'external'); | ||
| await settled(); | ||
| } else { | ||
| await createItemPage.createItem(itemType); | ||
| await settled(); | ||
| } | ||
| idRow = showItemPage.rows.filterBy('hasLabel').filterBy('rowLabel', 'ID')[0]; | ||
| itemID = idRow.rowValue; | ||
| let idRow = showItemPage.rows.filterBy('hasLabel').filterBy('rowLabel', 'ID')[0]; | ||
| const itemID = idRow.rowValue; | ||
| await page.visit({ item_type: itemType, id: itemID }); | ||
| await settled(); | ||
| await page.editForm.name(name).submit(); | ||
| await settled(); | ||
| idRow = aliasShowPage.rows.filterBy('hasLabel').filterBy('rowLabel', 'ID')[0]; | ||
| aliasID = idRow.rowValue; | ||
| const aliasID = idRow.rowValue; |
zofskeez
commented
Nov 9, 2022
| @@ -89,14 +88,14 @@ module('Acceptance | Enterprise | control groups', function (hooks) { | |||
| 'read -field=accessor sys/internal/ui/mounts/auth/userpass', | |||
| ]); | |||
| await settled(); | |||
| userpassAccessor = consoleComponent.lastTextOutput; | |||
| const userpassAccessor = consoleComponent.lastTextOutput; | |||
hellobontempo
approved these changes
Nov 9, 2022
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds prefer-const rule to eslint config and runs the fixer for existing violations. All changes (other than to .eslintrc) were done by the rule fixer other than where indicated.