UI: Remove prepended pki- to new engine files #17875
Conversation
hellobontempo
changed the title
| @@ -1,7 +1,7 @@ | |||
| import ApplicationAdapter from '../application'; | |||
| import { encodePath } from 'vault/utils/path-encoding-helpers'; | |||
|
|
|||
| export default class PkiIssuerEngineAdapter extends ApplicationAdapter { | |||
| export default class PkiIssuerAdapter extends ApplicationAdapter { | |||
There was a problem hiding this comment.
Following the pattern we've used elsewhere by keeping the folder name in front of the class name so this is PkiIssuerAdapter instead of IssuerAdapter
| @@ -1,3 +0,0 @@ | |||
| import PkiCertAdapter from './cert'; | |||
There was a problem hiding this comment.
not deleted, renamed to adapters/pki/certificate.js
| @@ -1,3 +0,0 @@ | |||
| import CertSerializer from './cert'; | |||
There was a problem hiding this comment.
not deleted, renamed to serializers/pki/certificate.js
| @@ -1,3 +0,0 @@ | |||
| import ApplicationSerializer from '../application'; | |||
There was a problem hiding this comment.
renamed to serializers/pki/role.js
| @@ -2,14 +2,14 @@ import Component from '@glimmer/component'; | |||
| import { action } from '@ember/object'; | |||
|
|
|||
| /** | |||
| * @module PkiKeyParameters | |||
There was a problem hiding this comment.
all of these components live in the pki/addon engine
| @@ -0,0 +1,3 @@ | |||
| import CertSerializer from './cert'; | |||
|
|
|||
| export default class PkiCertificateSerializer extends CertSerializer {} | |||
There was a problem hiding this comment.
Hm, we should probably rewrite this instead of extending but that's just a note for the future
There was a problem hiding this comment.
Yeah, I think that was the original intention
This reverts commit 8c122a3.
* append -old to non-engine pki models * revert old file name * remove -engine from all pki component, model, adapter and serializer files * add md file explaining pki naming
Now that all things PKI live in a
/pkifolder we are no longer prepending filenames withpki-Any newly created files for the pki redesign will follow this pattern (ex.
role.jsinstead ofpki-role.js). Aside fromcert.jsall of the old pki files are prepended withpki-and these will be removed when the PKI redesign is fully implemented.List of old files:
│── models/
│ │── pki/
│ │ │── cert.js
│ │ │── pki-config.js
│ │ │── pki-role.js
│ │── pki-ca-certificate-sign.js
│ │── pki-ca-certificate.js
│ │── pki-certificate-sign.js
│── serializers/
│ │── pki/
│ │ │── cert.js
│ │ │── pki-config.js
│ │ │── pki-role.js
│── adapters/
│ │── pki/
│ │ │── cert.js
│ │ │── pki-config.js
│ │ │── pki-role.js
│ │── pki-ca-certificate-sign.js
│ │── pki-ca-certificate.js
│ │── pki-certificate-sign.js
│ │── pki.js