Mark deprecated builtins Removed #18039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
2 times, most recently
from
a43dc69
to
3dea37d
Compare
mpalmi
force-pushed
the
remove-database-builtins
branch
from
d91812e
to
ea6b5e6
Compare
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
from
7c4064a
to
cb4460a
Compare
mpalmi
force-pushed
the
remove-database-builtins
branch
from
ea6b5e6
to
1eb63d8
Compare
mpalmi
changed the title
ncabatoff
reviewed
Dec 1, 2022
ncabatoff
approved these changes
Dec 1, 2022
mpalmi
commented
Dec 1, 2022
|
It looks like |
Thanks @calvn! I'm looking into it right now, but I suspect it's related to the branch that this is based on. Updates coming soon. |
mpalmi
force-pushed
the
remove-database-builtins
branch
from
3cbf5b3
to
0b3689c
Compare
|
Could you do a |
I thought about that and dropped this change, but on second thought, we can probably get rid of the |
calvn
reviewed
Dec 1, 2022
mpalmi
force-pushed
the
remove-database-builtins
branch
from
a468f22
to
4ee5fbf
Compare
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Remove logical database builtins * Drop removed builtins from registry keys * Update plugin prediction test * Remove app-id builtin * Add changelog
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Remove logical database builtins * Drop removed builtins from registry keys * Update plugin prediction test * Remove app-id builtin * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the logical database builtins for 1.13. This might need a bit more polish in the form of Factory stubbing, but getting it into CI to get some free testing.