improve kv CLI to remove data or custom metadata using kv patch #18067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
approved these changes
Nov 21, 2022
| @@ -147,8 +159,8 @@ func (c *KVPatchCommand) Run(args []string) int { | |||
| case len(args) < 1: | |||
| c.UI.Error(fmt.Sprintf("Not enough arguments (expected >1, got %d)", len(args))) | |||
| return 1 | |||
| case len(args) == 1: | |||
| c.UI.Error("Must supply data") | |||
| case len(c.flagRemoveData) == 0 && len(args) == 1: | |||
There was a problem hiding this comment.
Oh, great change to this check! I can definitely imagine scenarios where users only want to remove data.
| } | ||
|
|
||
| for _, key := range c.flagRemoveData { | ||
| newData[key] = nil |
There was a problem hiding this comment.
nit: Not sure if we wanted to include the same comment that you had above in the kv metadata patch implementation mentioning why the nil is important. What do you think?
There was a problem hiding this comment.
Sure, it would be good context! Thanks for the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18034