UI: pki engine breadcrumbs #18113
Merged
UI: pki engine breadcrumbs #18113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d2140dc.
hellobontempo
commented
Nov 28, 2022
hellobontempo
commented
Nov 28, 2022
hellobontempo
commented
Nov 28, 2022
zofskeez
reviewed
Nov 28, 2022
| constructor() { | ||
| super(...arguments); | ||
| this.args.breadcrumbs.forEach((breadcrumb) => { | ||
| assert('breadcrumb has a label key', Object.keys(breadcrumb).includes('label')); |
| <li> | ||
| <span class="sep">/</span> | ||
| {{#if breadcrumb.linkExternal}} | ||
| <LinkToExternal @route={{breadcrumb.path}}>{{breadcrumb.label}}</LinkToExternal> |
There was a problem hiding this comment.
Small nit but would route be a better name for the breadcrumb prop than path in case someone would think that it expects configuration/edit rather than configuration.edit?
There was a problem hiding this comment.
yeah - I had copied path over, but I agree route makes more sense here
zofskeez
approved these changes
Nov 28, 2022
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
* move mountPoint to parent PkiController and extend for engine routes * breadcrumb attempt * Revert "breadcrumb attempt" This reverts commit d2140dc. * make breadcrumb component * revert extending pki controller * move file import * generalize breadcrumb component * restructure files * remove docs * cleanup jsdoc and test * add to pki role details page * address comments * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple breadcrumb component to use until we can incorporate HDS components into Vault