feat(auth/ldap): allow passing the LDAP password via an env var #18225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable when authenticating via the CLI
|
This is a nice feature but will see if it passes the security test for the Vault team. I've dropped this into the Vault SME group for a look. Thanks @f4z3r |
maxcoulombe
approved these changes
Feb 23, 2023
|
Thanks for this contribution! The PR looks good, the CI failures are expected on forks afaik. |
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
…icorp#18225) * feat(auth/ldap): allow passing the LDAP password via an environment variable when authenticating via the CLI * chore(auth/ldap): add changelog entry for PR 18225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the requested enhancement from #13926 .