UI: PKI Role toolbar #18229
UI: PKI Role toolbar #18229
Conversation
| // } | ||
| import FlashMessageService from 'vault/services/flash-messages'; | ||
| import { inject as service } from '@ember/service'; | ||
| import errorMessage from 'vault/utils/error-message'; | ||
|
|
||
| // TODO: pull this in from route model once it's TS |
There was a problem hiding this comment.
I noticed this comment before - what does it mean? Just personal curiosity 😅
There was a problem hiding this comment.
In cloud-ui, since the route is also TS we can export it from that file and then import it, and it knows the shape based on what's returned in the model hook. Although here, we really just need the ember-data model which I haven't quite figured out how to do yet 😄
There was a problem hiding this comment.
oh wow! neat - thanks for explaining! I'll also keep an 👀 for how to do this 🤔
| @@ -8,7 +8,7 @@ export default class PkiCertificatesIndexRoute extends Route { | |||
|
|
|||
| beforeModel() { | |||
| // Must call this promise before the model hook otherwise it doesn't add OpenApi to record. | |||
| return this.pathHelp.getNewModel('pki/certificate', 'pki'); | |||
| return this.pathHelp.getNewModel('pki/certificate', this.secretMountPath.currentPath); | |||
| @@ -8,4 +8,16 @@ export default class RolesRoleDetailsRoute extends PkiRolesIndexRoute { | |||
| id: role, | |||
| }); | |||
| } | |||
|
|
|||
| setupController(controller, resolvedModel) { | |||
There was a problem hiding this comment.
Nice! I was wondering about a way to handle this in the controller 👏
| hooks.afterEach(async function () { | ||
| await logout.visit(); | ||
| await authPage.login(); | ||
| // Cleanup engine |
| await logout.visit(); | ||
| }); | ||
|
|
||
| module('roles', function (hooks) { |
There was a problem hiding this comment.
Is the thought to have a module for each resource?
There was a problem hiding this comment.
Yes, that was my thought. Then we don't need to make policies etc for the entire thing, we can test each section piecemeal
| } | ||
| }; | ||
|
|
||
| /** |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
||
| const validations = { | ||
| name: [{ type: 'presence', message: 'Name is required.' }], | ||
| }; | ||
|
|
||
| const fieldGroups = [ |
| @@ -1,6 +1,6 @@ | |||
| <Toolbar> | |||
| <ToolbarActions> | |||
| {{#if @role.canDelete}} | |||
| {{#if (or @role.updatePath.isLoading @role.canDelete)}} | |||
There was a problem hiding this comment.
So the toolbar action will show if the path is loading or they have permission?
For these capabilities conditionals - I remember a while ago you suggesting I explicitly check for false to avoid them not showing in case for some reason they're undefined. Not sure if you want to apply that same logic here? Although that was specifically for setting the disabled value of a link, so slightly different situation, plus the following is not very pretty 😵
{{#if (or @role.updatePath.isLoading (not (eq @role.canDelete false)))}}There was a problem hiding this comment.
There are other areas of the app where we use this or logic, but I do remember us checking explicitly for false at some point. The way I have it, if the capabilities aren't loaded yet the item will show, and once the value is loaded we can show the value.
however now that the capabilities values are getters instead of aliases, I think we can put the logic within the getter and that way we can rely on just a single check in the template! I'll update and you can let me know what you think
This PR adds capability checks on the role toolbar links, adds the ability to delete the role, and cleans up some breadcrumb and route logic (mostly prompted by test coverage)
Role toolbar links go to the right place (not all pages built out yet)
Role view when you only have read/list access
Role view when you have all engine permissions
