VAULT-8336 Fix default rate limit paths #18273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
commented
Dec 8, 2022
| @@ -724,15 +724,6 @@ func (m *Manager) RateLimitResponseHeadersEnabled() bool { | |||
| return m.config.EnableRateLimitResponseHeaders | |||
| } | |||
|
|
|||
| // RateLimitExemptPaths returns the list of exempt paths from all rate limit | |||
| // resource quotas from the Manager's configuration. | |||
| func (m *Manager) RateLimitExemptPaths() []string { | |||
There was a problem hiding this comment.
This function was never called (in OSS or Ent)
ccapurso
approved these changes
Dec 8, 2022
| @@ -724,15 +724,6 @@ func (m *Manager) RateLimitResponseHeadersEnabled() bool { | |||
| return m.config.EnableRateLimitResponseHeaders | |||
| } | |||
|
|
|||
| // RateLimitExemptPaths returns the list of exempt paths from all rate limit | |||
| // resource quotas from the Manager's configuration. | |||
| func (m *Manager) RateLimitExemptPaths() []string { | |||
|
Oh just realized something, if you're planning to backport this then you might want to move the docs to a separate PR so they aren't deployed upon merge of the backport PR. |
peteski22
approved these changes
Dec 9, 2022
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* VAULT-8336 Fix default rate limit paths * VAULT-8336 changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this never really worked, unfortunately. We check the request path against the default exempt list to see if the request path is a prefix of any, but since the request path was
sys/health, it wasn't a prefix of/v1/sys/health. After this change, everything seems to work as expected (assys/healthis indeed a prefix ofsys/health).The test I added will fail if this is broken again in the future, and all tests pass after this change (both OSS and Ent).
I updated the docs to make it clearer for users wanting to customize their set of defaults.