UI: PKI Sign Certificate #18343
Merged
UI: PKI Sign Certificate #18343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
approved these changes
Dec 15, 2022
| const data = serialNumber ? { serial_number: serialNumber } : { certificate }; | ||
| return this.ajax(`${this.buildURL()}/${encodePath(backend)}/revoke`, 'POST', { data }); | ||
| } | ||
| import PkiCertificateBaseAdapter from './base'; |
| { label: role, route: 'roles.role.details' }, | ||
| { label: 'sign certificate' }, | ||
| ]; | ||
| // This is updated on successful generate in the controller |
There was a problem hiding this comment.
❤️ thank you for the comment!
| urlForCreateRecord(modelName, snapshot) { | ||
| const { name, backend } = snapshot.record; | ||
| if (!name || !backend) { | ||
| const { role, backend } = snapshot.record; |
There was a problem hiding this comment.
nice role is much easier to infer the meaning from!
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This reverts commit a95d665.
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 25, 2023
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds form and page for signing CSR certificate