UI: download generated pki key #18381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, content, extension
hellobontempo
commented
Dec 15, 2022
| @@ -91,9 +91,8 @@ | |||
| {{/if}} | |||
| <DownloadButton | |||
| class="button is-ghost" | |||
| @data={{this.keyData}} | |||
There was a problem hiding this comment.
reordered args so that download service and button are consistent: filename, content/data, extension
hellobontempo
commented
Dec 15, 2022
| */ | ||
|
|
||
| export default class DownloadButton extends Component { | ||
| get extension() { |
There was a problem hiding this comment.
wanted order of getters to be consistent and match arg order...
hellobontempo
commented
Dec 15, 2022
| 'store', | ||
| 'version', | ||
| 'wizard', | ||
| 'secret-mount-path', |
There was a problem hiding this comment.
alphabetized? 🤷
hellobontempo
changed the title
hashishaw
reviewed
Dec 15, 2022
| /** | ||
| * @module DownloadButton | ||
| * DownloadButton components are an action button used to download data. Both the action text and icon are yielded. | ||
| * | ||
| * * NOTE: when using in an engine, remember to add the 'download' service to its dependencies (in /engine.js) and map to it in /app.js |
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* rename download service file * rename file again * add download-file service to engine * refactor download button to use service * refactor download service * finish refactor download service, make arg order consistent: filename, content, extension * add download button to key details * fix flaky test?
AnPucel
pushed a commit
that referenced
this pull request
Jan 25, 2023
* rename download service file * rename file again * add download-file service to engine * refactor download button to use service * refactor download service * finish refactor download service, make arg order consistent: filename, content, extension * add download button to key details * fix flaky test?
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* rename download service file * rename file again * add download-file service to engine * refactor download button to use service * refactor download service * finish refactor download service, make arg order consistent: filename, content, extension * add download button to key details * fix flaky test?
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
* rename download service file * rename file again * add download-file service to engine * refactor download button to use service * refactor download service * finish refactor download service, make arg order consistent: filename, content, extension * add download button to key details * fix flaky test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In macOS the key defaults to opening in Keychain Access because the format is
pem. The gif shows opening it in TextEdit for demo purposes.