ui: add capabilities to pki key model #18412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
changed the title
hashishaw
approved these changes
Dec 15, 2022
| <ToolbarLink @route="keys.key.edit" @model={{@key.model.name}}> | ||
| Edit key | ||
| </ToolbarLink> | ||
| {{#if @canDelete}} |
There was a problem hiding this comment.
Super excited about this pattern 🤩
There was a problem hiding this comment.
Same! great idea 🥇
| <nav class="menu"> | ||
| <ul class="menu-list"> | ||
| <li> | ||
| <LinkTo @route="keys.key.details" @model={{pkiKey.keyId}} @disabled={{eq pkiKey.canRead false}}> |
There was a problem hiding this comment.
Since the boolean is calculated on the model you could use not instead of eq ... false. Also do we want to used a passed arg here?
Suggested change
| <LinkTo @route="keys.key.details" @model={{pkiKey.keyId}} @disabled={{eq pkiKey.canRead false}}> | |
| <LinkTo @route="keys.key.details" @model={{pkiKey.keyId}} @disabled={{not @canRead}}> |
There was a problem hiding this comment.
yeah - I was wondering about doing something similar to what I did for @canGenerateKey so like the following. If we are okay with reading those capabilities just based on the first model?
@canReadKey={{this.model.keyModels.firstObject.canReadKey}}There was a problem hiding this comment.
I thought we didn't want to use not in case the capability is undefined for some reason?
There was a problem hiding this comment.
oohhh ^ disregard, forgot its explicitly checking for false in the model getter now
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 6aae14b.
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* add capabilities to pki key model * move key list from route into component * rename test file * rename test file * add tests * pass capabilities directly to key list componente * add test for key list component * rename test files * remove href assertion
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add capabilities to pki key model * move key list from route into component * rename test file * rename test file * add tests * pass capabilities directly to key list componente * add test for key list component * rename test files * remove href assertion
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add capabilities to pki key model * move key list from route into component * rename test file * rename test file * add tests * pass capabilities directly to key list componente * add test for key list component * rename test files * remove href assertion
AnPucel
pushed a commit
that referenced
this pull request
Jan 25, 2023
* add capabilities to pki key model * move key list from route into component * rename test file * rename test file * add tests * pass capabilities directly to key list componente * add test for key list component * rename test files * remove href assertion
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* add capabilities to pki key model * move key list from route into component * rename test file * rename test file * add tests * pass capabilities directly to key list componente * add test for key list component * rename test files * remove href assertion
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
* add capabilities to pki key model * move key list from route into component * rename test file * rename test file * add tests * pass capabilities directly to key list componente * add test for key list component * rename test files * remove href assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capabilities to the key model and wraps actions in the key route