Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12112: add openapi response structures for /sys/auth/* endpoints #18465

Merged
merged 9 commits into from Feb 16, 2023
Merged

VAULT-12112: add openapi response structures for /sys/auth/* endpoints #18465

merged 9 commits into from Feb 16, 2023

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Dec 19, 2022 •
edited

Path Operation response docs
/sys/auth READ link
/sys/auth/{path}/tune READ link
/sys/auth/{path}/tune UPDATE link
/sys/auth/{path} READ link docs
/sys/auth/{path} UPDATE link
/sys/auth/{path} DELETE link

tests added

@dhuckins dhuckins added this to the 1.13.0-rc1 milestone Dec 22, 2022
@dhuckins dhuckins changed the base branch from dh/response-structures-sys-1 to main December 22, 2022 19:48
averche
averche reviewed Dec 23, 2022
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue with the response otherwise LGTM. Could you please also update the PR title to something more descriptive

@dhuckins dhuckins changed the title dh/response structures sys 1 auth add response structures for /sys/auth/* endpoints Dec 23, 2022
@dhuckins dhuckins changed the title add response structures for /sys/auth/* endpoints add openapi response structures for /sys/auth/* endpoints Dec 23, 2022
dhuckins and others added 2 commits December 23, 2022 12:28
@dhuckins @averche
Update vault/logical_system_paths.go
18ac1d4 
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
@dhuckins
its TypeString
2702190 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins dhuckins marked this pull request as ready for review December 23, 2022 17:29
@dhuckins
Copy link
Contributor Author

@averche added field

averche
averche approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhuckins dhuckins changed the title add openapi response structures for /sys/auth/* endpoints VAULT-12112: add openapi response structures for /sys/auth/* endpoints Jan 5, 2023
@dhuckins
use nil for dynamic fields
b6aae43 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins
Merge branch 'main' of github.com:hashicorp/vault into dh/response-st…
150c919 
…ructures-sys-1-auth
@dhuckins
test auth endpoint schema
78f6763 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins
kicking off ci
db4e6ef
@dhuckins dhuckins merged commit 6bab86f into main Feb 16, 2023
@dhuckins dhuckins deleted the dh/response-structures-sys-1-auth branch February 16, 2023 20:03
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@dhuckins @averche
VAULT-12112: add openapi response structures for /sys/auth/* endpoi…
b8d7703 
…nts (hashicorp#18465)

* added responses to /sys/auth/.../tune

* add response structure for auth/...

* added changelog

* Update vault/logical_system_paths.go

Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>

* its TypeString

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

* use nil for dynamic fields

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

* test auth endpoint schema

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>

* kicking off ci

---------

Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

@lursu lursu Awaiting requested review from lursu

@AnPucel AnPucel Awaiting requested review from AnPucel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhuckins @averche