ui: add ability to edit pki key #18490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hellobontempo
commented
Dec 20, 2022
hellobontempo
commented
hashishaw
approved these changes
Dec 20, 2022
| @@ -1,5 +1,5 @@ | |||
| <label for={{@attr.name}} class="is-label" data-test-readonly-label> | |||
| {{this.labelString}} | |||
| {{or @label this.labelString}} | |||
There was a problem hiding this comment.
nit: debating whether this should be in the getter for this.labelString. On one hand, this makes it very clear that passing @label in explicitly will override any other calculations. But, we already have a method here for calculating the label and it could easily live there 🤔
There was a problem hiding this comment.
I had it that way initially and and thought the getter had a lot going on as well - but I'm happy to move it back there!
Another thought is I could do something similar to the above, and create a let for keyType and leave this component alone. This also gives us the benefit of including the option's subtext... 🤔 Any opinion?
| {{/each}} | ||
| {{else}} | ||
| {{! only keyName is edit-able }} | ||
| {{#let (find-by "name" "keyName" @model.formFields) as |attr|}} |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashishaw
pushed a commit
that referenced
this pull request
Dec 21, 2022
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
joshbrand
pushed a commit
that referenced
this pull request
Jan 11, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
AnPucel
pushed a commit
that referenced
this pull request
Jan 25, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
* add edit form * refactor readonly field * refactor conditional in key form * remove model validations from edit form * update namespace reminder opy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.