only update SCADA metadata if status changes #18585
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
divyaac
approved these changes
Jan 3, 2023
biazmoreira
approved these changes
Jan 4, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* only update SCADA metadata if status changes * add changelog entry
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* only update SCADA metadata if status changes * add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault nodes use SCADA session metadata to denote whether they are
ACTIVE,STANDBY, orPERF-STANDBY. Providing this metadata is done by callingUpdateMetaon the SCADA provider. This is currently done every 5 seconds. A Vault node should only update its SCADA metadata if its status changes (i.e. leadership in the cluster has shifted).