add core state lock deadlock detection config option v2 #18604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Jan 5, 2023
ncabatoff
reviewed
Jan 5, 2023
elliesterner
force-pushed
the
detect_deadlocks_v2_es
branch
from
b1d05d6
to
fc4f1c7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ncabatoff
reviewed
Jan 9, 2023
ncabatoff
reviewed
Jan 9, 2023
| @@ -1633,6 +1635,7 @@ func NewTestCluster(t testing.T, base *CoreConfig, opts *TestClusterOptions) *Te | |||
| } | |||
|
|
|||
| if base != nil { | |||
| coreConfig.DetectDeadlocks = TestDeadlockDetection | |||
There was a problem hiding this comment.
This is very close to what I want. The only catch is, there's no way to turn it off. Maybe that's ok though, I can't come up with a good reason why I should have to be able to, given that I can use the tag. We can always revisit this later if need be.
ncabatoff
approved these changes
Jan 9, 2023
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* add core state lockd eadlock detection config option v2 * add changelog * split out NewTestCluster function to maintain build flag * replace long func with constant * remove line * rename file, and move where detect deadlock flag is set
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR based on #17020