Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12144: add openapi responses for /sys/tools endpoints #18626

Merged
merged 9 commits into from Mar 24, 2023
Merged

VAULT-12144: add openapi responses for /sys/tools endpoints #18626

merged 9 commits into from Mar 24, 2023

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Jan 6, 2023 •
edited

Path Operation response docs
/sys/tools/hash UPDATE link
/sys/tools/hash/{urlalgorithm} UPDATE link
/sys/tools/random UPDATE link
/sys/tools/random/{source} UPDATE link
/sys/tools/random/{source}/{urlbytes} UPDATE link
/sys/tools/random/{urlbytes} UPDATE link

added response structure tests

@dhuckins
add struct for /sys/tools/hash
44dc4d1 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins
added responses for /sys/tools paths
653e863 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins dhuckins added this to the 1.13.0-rc1 milestone Jan 6, 2023
@dhuckins dhuckins requested a review from a team January 6, 2023 22:20
@dhuckins dhuckins marked this pull request as ready for review January 6, 2023 22:20
@dhuckins
verify respose structure for hash
5f7da8d 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins
verify respose structure for hash/random
2a0b949 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins dhuckins requested review from AnPucel and a team January 20, 2023 17:20
@dhuckins
Merge branch 'main' of github.com:hashicorp/vault into dh/response-st…
2ce44d5 
…ructures-sys-3-tools
@dhuckins
use newer testing funct
36888b7 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@dhuckins dhuckins requested a review from averche February 2, 2023 22:11
dhuckins
dhuckins commented Feb 3, 2023
View reviewed changes
vault/logical_system_test.go Outdated
if err != nil {
t.Fatalf("err: %v", err)
}
schema.ValidateResponse(
t,
schema.FindResponseSchema(t, paths, 0, req.Operation),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to update this one

@dhuckins
use new test method
f7a9b51 
Signed-off-by: Daniel Huckins <dhuckins@users.noreply.github.com>
@averche averche modified the milestones: 1.13.0-rc1, 1.14 Feb 13, 2023
This was referenced Feb 15, 2023
Merged
Merged
Merged
Merged
@dhuckins dhuckins enabled auto-merge (squash) March 24, 2023 21:22
@dhuckins dhuckins closed this Mar 24, 2023
auto-merge was automatically disabled March 24, 2023 21:23

Pull request was closed

@dhuckins dhuckins reopened this Mar 24, 2023
@dhuckins dhuckins enabled auto-merge (squash) March 24, 2023 21:24
@dhuckins dhuckins merged commit c913950 into main Mar 24, 2023
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

@AnPucel AnPucel Awaiting requested review from AnPucel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhuckins @AnPucel @averche