UI: PKI config refactor #18639
Merged
UI: PKI config refactor #18639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
approved these changes
Jan 10, 2023
| import { setupTest } from 'vault/tests/helpers'; | ||
| import { setupMirage } from 'ember-cli-mirage/test-support'; | ||
|
|
||
| module('Unit | Adapter | pki/config', function (hooks) { |
hashishaw
force-pushed
the
ui/pki-config-refactor
branch
from
050bb41
to
65fd0ef
Compare
| @lazyCapabilities(apiPath`${'backend'}/issuers/import/bundle`, 'backend') importBundlePath; | ||
| @lazyCapabilities(apiPath`${'backend'}/issuers/generate/root/${'type'}`, 'backend', 'type') | ||
| generateIssuerRootPath; | ||
| @lazyCapabilities(apiPath`${'backend'}/issuers/generate/intermediate/${'type'}`, 'backend', 'type') |
There was a problem hiding this comment.
Just a note for later - I think both of these generate capability paths will have to be without type since that's selected by the user in the form and so it will always be undefined since type won't exist on the model until it's selected?
| shouldUseIssuerEndpoint() { | ||
| const { config } = this.args; | ||
| // To determine which endpoint the config adapter should use, | ||
| // we want to check highest-privileged capabilities and use the | ||
| // fallback (issuer path) if user does not have permissions. | ||
| // we want to check capabilities on the newer endpoints (those |
There was a problem hiding this comment.
thank you for this comment!
joshbrand
pushed a commit
that referenced
this pull request
Jan 11, 2023
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 25, 2023
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the PKI Configure flow so that all the options share one model. Follow-on work will involve creating form components for each of the other options.