UI: pki cross-sign issuers #18695
UI: pki cross-sign issuers #18695
Conversation
…anually add to pki/action
| @@ -0,0 +1 @@ | |||
| export { default } from 'core/helpers/img-path'; | |||
There was a problem hiding this comment.
This is right for using a helper in an engine, right? I'm noticing there's a loading lag - wondering if I did something incorrectly 🤔
There was a problem hiding this comment.
That looks right! Shouldn't be a lag loading the actual component itself. Not sure about the image itself which depend on size and location.
There was a problem hiding this comment.
Yeah - it's just the image (you can see it in the gif that it shows up a little after the page loads). I haven't actively developed with one on the page, so just wanted to confirm that was working as expected 😄
| </div> | ||
| <div class="box is-fullwidth has-only-top-shadow"> | ||
| {{#each this.signedIssuers as |crossSignRow|}} | ||
| <div class="box is-marginless no-top-shadow has-slim-padding"> |
There was a problem hiding this comment.
I considered making this table (Lines 20- 66) a component <InfoTableColumns>, but there aren't any current design plans to use a table column display elsewhere. I can pull out into a component, though, if preferred!
There was a problem hiding this comment.
This component isn't terribly large and if we're unsure if the pattern will reappear I would suggest leaving as is and we can always come back and rework it into a generic component if need be.
| ); | ||
| this.signedIssuers.addObject({ ...data, hasError: false }); | ||
| } catch (error) { | ||
| this.signedIssuers.addObject({ |
There was a problem hiding this comment.
This could be a follow-on, but have we tested this workflow with various permissions? I wonder if this error format is going to make sense if they run into a permissions error on one of the earlier steps 🤔
There was a problem hiding this comment.
Definitely a great point to include in testing. I haven't tested but any errors that happen from making API requests in the crossSignIntermediate method are caught and should be added on line 92 with hasError: errorMessage(error).
There was a problem hiding this comment.
Yay! One step better would be to know on which path the permission was denied, but at least we get something out of the box 🎉
| @@ -1,3 +1,14 @@ | |||
| import Route from '@ember/routing/route'; | |||
| import PkiIssuerIndexRoute from './index'; | |||
| // TODO comment in before merging | |||
There was a problem hiding this comment.
Do you want to comment this back in?
* make cross-sign component * remove type from obj-list-input * finish skeleton of component * handle change on init * finish cross-sign form * add cancel transition * update pki/issuer adapter to accept backend passed from adapterOptions * first draft of cross-signing issuers component * refactor to accommodate listing signed certs * changes to config adapter and model, likely will need to revert and manually add to pki/action * add args to infotooltip, move header to cross-sign route * use pki/action model * move header to route file * finish displaying signed certificates * finish styling * add issuer id to cross-sign breadcrumbs * add parsed cert data to requests * add status count * add error banner back
Cross-signing issuers in the UI, along with error messages
Updated screenshot with success/error count, buttons and alert/warning banners:
To do in follow-on PR: