UI: PKI Generate Root Form #18712
Merged
UI: PKI Generate Root Form #18712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @model={{this.model}} | ||
| @onCancel={{transition-to "vault.cluster.secrets.backend.pki.issuers.index"}} | ||
| @onSave={{transition-to "vault.cluster.secrets.backend.pki.issuers.index"}} |
There was a problem hiding this comment.
Would saving take us to the generated root cert?
There was a problem hiding this comment.
I used to have a note about parsing the issuer from the save response and passing that for the onSave transition. I plan on looking into that with the generate-csr work -- for now, I figured this is a reasonable if not ideal transition
There was a problem hiding this comment.
Yeesh - the pki workflow flow 🤯. Yeah, sounds more than reasonable!
hellobontempo
approved these changes
Jan 17, 2023
| this.showGroup = isOpen ? group : null; | ||
| } | ||
|
|
||
| get defaultFields() { |
There was a problem hiding this comment.
Having a component getter makes this so much clearer. Instead of passing a huge array of objects with arrays of attrs as groupPropertyNames to the model decorator (like we did in pki/roles)
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
dhuckins
pushed a commit
that referenced
this pull request
Jan 19, 2023
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new component in the PKI engine,
PkiGenerateRoot. It also renames the model/adapter/serializerpki/configtopki/actionto better represent that the actions it encompasses can happen in places other than initial PKI configuration.Form is rendered on config if Generate Root is selected
Form is rendered from issuers > generate root selection
Follow-on tasks:
pki/actionserializerpki-key-parameters