Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: VAULT-12670 Update pki list view labels for list items #18744

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Jan 17, 2023

Updated the labels for list items to be consistent in ui.

Before:
Screen Shot 2023-01-17 at 3 13 52 PM

After:
Screen Shot 2023-01-17 at 3 13 20 PM

@kiannaquach kiannaquach marked this pull request as ready for review January 17, 2023 23:14
@kiannaquach kiannaquach added this to the 1.13.0-rc1 milestone Jan 17, 2023
@kiannaquach kiannaquach changed the title VAULT-12670 Update pki list view labels for list items ui: VAULT-12670 Update pki list view labels for list items Jan 17, 2023
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks! Just a few failing tests to look at.

@kiannaquach kiannaquach merged commit 2837cea into main Jan 18, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-12570/pki-key-list-view branch January 18, 2023 17:36
dhuckins pushed a commit that referenced this pull request Jan 19, 2023
* VAULT-12670 Update pki list view labels for list items

* Fix failing tests!
dhuckins pushed a commit that referenced this pull request Jan 19, 2023
* VAULT-12670 Update pki list view labels for list items

* Fix failing tests!
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
…#18744)

* VAULT-12670 Update pki list view labels for list items

* Fix failing tests!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants