Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: VAULT-12357 VAULT-12356 Add PKI Beta tag and Modal #18761

Merged
merged 6 commits into from
Jan 20, 2023
Merged

UI: VAULT-12357 VAULT-12356 Add PKI Beta tag and Modal #18761

merged 6 commits into from
Jan 20, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Jan 18, 2023 •
edited

Description

  • VAULT-12356 go to new pki w/ modal
  • VAULT-12357 back to old pki tag
  • User can go to new PKI from old PKI and vice versa
  • Add pki beta tag and modal to SecretListHeader
  • When user clicks on "Don't show me again", a property called hidePkiBetaModal will save in localStorage and if unchecked it will remove the property.

chrome-capture-2023-0-20

zofskeez
zofskeez reviewed Jan 18, 2023
View reviewed changes
ui/app/app.js Outdated Show resolved Hide resolved
@kiannaquach kiannaquach added this to the 1.13.0-rc1 milestone Jan 19, 2023
@kiannaquach kiannaquach marked this pull request as ready for review January 20, 2023 16:37
hellobontempo
hellobontempo requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! 😄 Just a couple ✨ glimmer things then we're good to go! 🚀

ui/app/styles/pki/pki-beta.scss Outdated Show resolved Hide resolved
ui/app/styles/pki/pki-beta.scss Outdated Show resolved Hide resolved
ui/lib/core/addon/components/secret-list-header.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/secret-list-header.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/secret-list-header.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/secret-list-header.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/secret-list-header.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/secret-list-header.js Show resolved Hide resolved
ui/tests/integration/components/secret-list-header-test.js Show resolved Hide resolved
ui/tests/integration/components/secret-list-header-test.js Show resolved Hide resolved
hellobontempo
hellobontempo approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just need to add the id then good to go!

Also feel free to rename the PR from the auto-generated label. The PR names are helpful for posterity when searching for closed ones. So this could be "UI: Add PKI Beta tag and Modal" or something 😄

@kiannaquach kiannaquach changed the title VAULT-12357 VAULT-12356 PKI beta UI: VAULT-12357 VAULT-12356 Add PKI Beta tag and Modal Jan 20, 2023
@kiannaquach kiannaquach merged commit 7a92b62 into main Jan 20, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-12356/pki-beta-from-old branch January 20, 2023 20:02
@hashishaw hashishaw mentioned this pull request Jan 27, 2023
Merged
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@kiannaquach
UI: VAULT-12357 VAULT-12356 Add PKI Beta tag and Modal (hashicorp#18761)
dbe5976 
* Initial beta modal set up

* Add back to old pki from engine

* Remove commented out code

* Add stylesheet and tests!

* Address feedback!

* Add id to input
@hellobontempo hellobontempo mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez left review comments

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiannaquach @zofskeez @hellobontempo