Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: VAULT-12820 Fix styling for pki beta badge #18782

Merged
merged 3 commits into from
Jan 20, 2023
Merged

UI: VAULT-12820 Fix styling for pki beta badge #18782

merged 3 commits into from
Jan 20, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Jan 20, 2023 •
edited

Description

  • Add underline to beta badge link!
  • Fix colors + add bold to text to match designs

Before:
Screen Shot 2023-01-20 at 1 36 50 PM

After:
Screen Shot 2023-01-20 at 1 38 41 PM
to compare here are the designs:
Screen Shot 2023-01-20 at 1 39 12 PM

@kiannaquach kiannaquach added this to the 1.13.0-rc1 milestone Jan 20, 2023
@kiannaquach kiannaquach changed the title VAULT-12820 Add underline to beta badge UI: VAULT-12820 Fix styling for pki beta badge Jan 20, 2023
@kiannaquach kiannaquach marked this pull request as ready for review January 20, 2023 21:40
hellobontempo
hellobontempo approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I was wondering about the design discrepancies, but just figured I'd missed a conversation 😅

I noticed like 56 has an action helper - I think this can be changed to fn?

@kiannaquach kiannaquach merged commit e5c7e8f into main Jan 20, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-12820/add-underline-to-beta-badge branch January 20, 2023 23:29
@hashishaw hashishaw mentioned this pull request Jan 27, 2023
Merged
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@kiannaquach
UI: VAULT-12820 Fix styling for pki beta badge (hashicorp#18782)
d9ebc17 
* Add underline to beta badge

* Update tag styles

* Use fn instead of action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiannaquach @hellobontempo