Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: VAULT-12355 return to old pki from configuration #18791

Merged
merged 2 commits into from
Jan 23, 2023
Merged

UI: VAULT-12355 return to old pki from configuration #18791

merged 2 commits into from
Jan 23, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Jan 23, 2023 •
edited

Description

  • Add banner for users to return from new pki configuration to old pki configuration See designs
    beta

Screen Shot 2023-01-23 at 9 13 14 AM

@kiannaquach kiannaquach added this to the 1.13.0-rc1 milestone Jan 23, 2023
@kiannaquach kiannaquach marked this pull request as ready for review January 23, 2023 17:25
hashishaw
hashishaw approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🚀

@kiannaquach kiannaquach modified the milestone: 1.13.0-rc1 Jan 23, 2023
@mladlow mladlow modified the milestone: 1.13.0-rc1 Jan 23, 2023
@kiannaquach kiannaquach merged commit 3ded138 into main Jan 23, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-12355/pki-beta-configuration branch January 23, 2023 20:59
@hashishaw hashishaw mentioned this pull request Jan 27, 2023
Merged
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@kiannaquach
VAULT-12355 return to old pki from configuration (hashicorp#18791)
273b298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiannaquach @hashishaw @mladlow