Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: VAULT-12949 use overview card component for kubernetes overview #18845

Merged
merged 4 commits into from
Jan 26, 2023
Merged

UI: VAULT-12949 use overview card component for kubernetes overview #18845

merged 4 commits into from
Jan 26, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Jan 25, 2023 •
edited

Description:

kub

With Roles:

  • shows number of roles and View roles link

Screen Shot 2023-01-25 at 2 41 44 PM

Without Roles:

  • show None and has Create role link

Screen Shot 2023-01-25 at 2 43 09 PM

@kiannaquach kiannaquach added this to the 1.13.0-rc1 milestone Jan 25, 2023
@kiannaquach kiannaquach marked this pull request as ready for review January 25, 2023 23:11
zofskeez
zofskeez reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work updating this to use the common component! Just one question in regards to a11y best practices with the added form.

ui/lib/kubernetes/addon/components/page/overview.hbs Outdated Show resolved Hide resolved
@kiannaquach
Copy link
Contributor Author

@zofskeez Removed the form element for generate credentials form card in k8's and the form cards in pki!

zofskeez
zofskeez approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kiannaquach kiannaquach enabled auto-merge (squash) January 26, 2023 00:03
@kiannaquach kiannaquach merged commit dbefdc3 into main Jan 26, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-12949/kubernetes-overview-refactor branch January 26, 2023 00:11
@hashishaw hashishaw mentioned this pull request Jan 27, 2023
Merged
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
@kiannaquach
UI: VAULT-12949 use overview card component for kubernetes overview (h…
c77bc38 
…ashicorp#18845)

* VAULT-12949 use overview card component for kubernetes overview

* Add a little more spacing

* Add margin to pki overview form

* Remove form element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiannaquach @zofskeez