Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix cancel button on role transform form #19135

Merged
merged 4 commits into from Feb 10, 2023

Conversation

hashishaw
Copy link
Collaborator

Before this change, clicking "Cancel" from the create transform role page would result in this error:

Error screen after cancel

After the change, clicking Cancel from both the edit and create screens properly redirects to the show or list pages, respectively.

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.10.x labels Feb 10, 2023
@hashishaw hashishaw added this to the 1.10.11 milestone Feb 10, 2023
@hashishaw hashishaw marked this pull request as ready for review February 10, 2023 20:12
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants