UI: sets operationNone for a kmip role if no checkboxes are selected #19139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
approved these changes
Feb 10, 2023
This was referenced Feb 10, 2023
hellobontempo
deleted the
ui/VAULT-13548/fix-kmip-checkboxes-role-form
branch
jayant07-yb
pushed a commit
to jayant07-yb/hashicorp-vault-integrations
that referenced
this pull request
Mar 15, 2023
…ashicorp#19139) * fix operationNon not being set on save * add changelog * fix overriding operationAll * remove mirage file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a kmip role still allowing all operations even if all of the checkboxes are deselected. This is because
operation_nonewas only being set/unset when the blue toggle was clicked (see in gif only after it is toggled, then the operations are removed). But if a user unchecksAllow this role to perform all operationsthe change does not persist and all operations are still allowed.This also fixes a typo that made the server operation:
Discover versionsinput render without a checkbox