Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - approle naming syntax update #19369

Merged
merged 1 commit into from
Feb 27, 2023
Merged

docs - approle naming syntax update #19369

merged 1 commit into from
Feb 27, 2023

Conversation

rowansmithhc
Copy link
Member

@rowansmithhc rowansmithhc commented Feb 26, 2023

Documentation does not currently detail the accepted naming scheme for approle roles, this aims to provide clarity based on customer feedback. https://github.com/hashicorp/vault/blob/main/sdk/framework/path.go#L16-L18 details the regex used.

vercel preview: https://vault-paqwqha1v-hashicorp.vercel.app/vault/api-docs/auth/approle#create-update-approle

Documentation does not currently detail the accepted naming scheme for approle roles, this aims to provide clarity based on customer feedback. https://github.com/hashicorp/vault/blob/main/sdk/framework/path.go#L16-L18 details the regex used.
Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yhyakuna yhyakuna merged commit 538bb79 into main Feb 27, 2023
@yhyakuna yhyakuna deleted the docs-approle-naming branch February 27, 2023 20:08
yhyakuna pushed a commit that referenced this pull request Feb 28, 2023
Documentation does not currently detail the accepted naming scheme for approle roles, this aims to provide clarity based on customer feedback. https://github.com/hashicorp/vault/blob/main/sdk/framework/path.go#L16-L18 details the regex used.
yhyakuna pushed a commit that referenced this pull request Feb 28, 2023
Documentation does not currently detail the accepted naming scheme for approle roles, this aims to provide clarity based on customer feedback. https://github.com/hashicorp/vault/blob/main/sdk/framework/path.go#L16-L18 details the regex used.
yhyakuna added a commit that referenced this pull request Feb 28, 2023
Documentation does not currently detail the accepted naming scheme for approle roles, this aims to provide clarity based on customer feedback. https://github.com/hashicorp/vault/blob/main/sdk/framework/path.go#L16-L18 details the regex used.

Co-authored-by: Rowan Smith <86935689+rowansmithhc@users.noreply.github.com>
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
Documentation does not currently detail the accepted naming scheme for approle roles, this aims to provide clarity based on customer feedback. https://github.com/hashicorp/vault/blob/main/sdk/framework/path.go#L16-L18 details the regex used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants