UI: Mount PKI options + allowed_managed_keys #19791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiannaquach
reviewed
Apr 7, 2023
| @@ -56,6 +56,17 @@ export default class MountBackendForm extends Component { | |||
| } | |||
| } | |||
|
|
|||
| typeChangeSideEffect(type) { | |||
| if (!this.args.mountType === 'secret') return; | |||
There was a problem hiding this comment.
Are we checking to see if there's no mountType or this.args.mountType !== 'secret'? If we're checking if there's no mountType, it won't ever equal 'secret'?
There was a problem hiding this comment.
Good question! Here I essentially want to continue with the side effects only if mountType is secret (auth is the other possibility). If it makes more sense to read as below, I'm happy to update it
if (this.args.mountType === 'secret') {
// do stuff
}
There was a problem hiding this comment.
Got it - that makes sense to me! I was reading it like !this.args.mountType === 'secrets' but it's really just checking (!(this.args.mountType === 'secrets')). I think we can keep it as it is! Thanks for clarifying 🙃
kiannaquach
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizes the secret engine mount settings for PKI type. Includes TTL's moved out of the toggle, and max TTL automatically gets a value of ~10years.
This PR also adds the
allowed_managed_keysparam to this and all other secret engine types.