UI: Namespace area fixes #19799
Merged
UI: Namespace area fixes #19799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
reviewed
Mar 28, 2023
ui/app/adapters/namespace.js
Outdated
There was a problem hiding this comment.
thanks for turning into class based!
Monkeychip
reviewed
Mar 28, 2023
| @@ -4,21 +4,21 @@ | |||
| */ | |||
|
|
|||
| import Model, { attr } from '@ember-data/model'; | |||
| import { computed } from '@ember/object'; | |||
| import { expandAttributeMeta } from 'vault/utils/field-to-attrs'; | |||
| import { withExpandedAttributes } from 'vault/decorators/model-expanded-attributes'; | |||
Monkeychip
reviewed
Mar 28, 2023
| @@ -35,7 +35,7 @@ | |||
| {{#let (concat this.currentNamespace (if this.currentNamespace "/") list.item.id) as |targetNamespace|}} | |||
| {{#if (includes targetNamespace this.accessibleNamespaces)}} | |||
| <li class="action"> | |||
| <NamespaceLink @targetNamespace={{targetNamespace}} @class="is-block"> | |||
| <NamespaceLink @targetNamespace={{targetNamespace}} @unparsed={{true}} @class="is-block"> | |||
There was a problem hiding this comment.
would you mind adding documentation to the NamespaceLink component? Add unparsed parma, etc.
There was a problem hiding this comment.
I'll add a comment about unparsed, but there's a lot in there that I have no idea what's going on 😬
Monkeychip
approved these changes
Mar 28, 2023
hashishaw
force-pushed
the
ui/namespace-fixes
branch
from
32212e4
to
5571517
Compare
hashishaw
added a commit
that referenced
this pull request
Apr 6, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 6, 2023
This was referenced Apr 6, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 6, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 7, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 7, 2023
hashishaw
added a commit
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues with the namespaces area of the UI:
Goes to the wrong link if namespace has dots
Shows blue info banner from unexpected param
After