Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Validation Warnings #19913

Merged
merged 4 commits into from
Apr 3, 2023
Merged

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Mar 31, 2023

To address the issue of unintentionally adding whitespace to a secrets engine or auth method mount path, this PR adds an alert to warn the user when whitespace is detected. The model validations decorator was updated to support warn level validations and warnings are built alongside any errors when invoking model.validate().

Screen.Recording.2023-03-31.at.11.59.18.AM.mov

Closes #8268

@zofskeez zofskeez added the ui label Mar 31, 2023
@zofskeez zofskeez added this to the 1.14 milestone Mar 31, 2023
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefs-kiss: Gorgeous, love it! Thanks for this, great work!

@zofskeez zofskeez marked this pull request as ready for review March 31, 2023 19:48
@zofskeez zofskeez merged commit a5bba9c into main Apr 3, 2023
@zofskeez zofskeez deleted the ui/VAULT-15070/model-validations-warnings branch April 3, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrimSpace secret engine path
2 participants